Skip to content

[SE-2497] Avoid sending deployment failure urgent e-mails in deployments triggered by OpenCraft members

Giang Nguyen requested to merge github/fork/giang-nghg/giang/avoid-urgent-email-on-internal-failures into master

This PR add a validation to avoid sending emails to users on appserver spawn failures if the action was created by a member of OpenCraft

Mostly copied from https://github.com/open-craft/opencraft/pull/617, the only major difference is that this test is no longer needed (and in the original PR it always passes anyway, so it doesn't test anything).

JIRA tickets: SE-2497

Testing instructions

  • Create a new deployment from the new interface, make it fail and check email is sended
  • Redeploy instances using instance_redeploy command and check that email is not sended
  • Create a new deployment from the manage site and check that no email is sent if it fails

Reviewers

@pkulkark @mtyaka

Merge request reports