Skip to content

[BB-960] Don't fail when Github user does not exist

Boros Gábor requested to merge paulo/fix-github-fail into master

Created by: viadanna

Description

This PR implements a check for the Github users before provisioning the servers to prevent failures when a user isn't found.

Testing

  1. Check out this branch in Stage and restart the server.
  2. Replace a user's Github handle with one that does not exist.
  3. Start provisioning a new App Server.
  4. Make sure it does not fail when adding users, as the user that does not map to a Github user does not show the github key.
2019-06-25 10:29:07-0300 INFO
changed: [54.38.70.171] => (item={u'type': u'admin', u'name': u'viadannap'})
2019-06-25 10:29:07-0300 INFO
changed: [54.38.70.171] => (item={u'github': True, u'type': u'admin', u'name': u'viadanna'})

Merge request reports