Skip to content

[SE-461] Put the forum heartbeat checks in EDXAPP_ENV_EXTRA instead of EDXAPP_LMS_ENV_EXTRA

Daniel Clemente Laboreo requested to merge clemente/extended-heartbeat-in-lms-and-cms into master

With the current edx_sandbox.yml playbook, EDXAPP_LMS_ENV_EXTRA and EDXAPP_ENV_EXTRA don't merge their values when both are passed together. One overrides the other.

This PR is to avoid passing EDXAPP_LMS_ENV_EXTRA and using EDXAPP_ENV_EXTRA instead. The extended heartbeat will be available from LMS and CMS (I'm hoping the 2nd part works, since the forum heartbeat check is unrelated to LMS and CMS)

JIRA tickets: SE-461 Discussions: None Dependencies: None Screenshots: None Sandbox URL: None yet Merge deadline: None

Testing instructions:

  1. Install in stage
  2. Deploy a normal server
  3. Check both https://xxxxxxxxxx.opencraft.hosting/heartbeat?extended and https://studio-xxxxxxxxxx.opencraft.hosting/heartbeat?extended, both should work and return the same
  4. Deploy a server with a custom EDXAPP_ENV_EXTRA and check that the final server will have the custom settings plus our heartbeat settings, combined (you can check lms.env.json). And that the heartbeat still works in LMS and CMS.

Reviewers

  • @pomegranited

Author concerns: Will the forum heartbeat work in Studio even though some code lives in a lms.… package? Settings: None

Merge request reports