Skip to content

Vagrant config and Makefile improvements

Boros Gábor requested to merge github/fork/brousch/makefile_install into master

Created by: brousch

These are changes to allow a dev instance to be run via Vagrant. some new Makefile commands are included and the README has been updated to reflect the changes. Some changes that may raise eyebrows are:

.env.vagrant: I'm not sure about all of the settings in the .env file, but this is sufficient for running a dev instance using SQLite. Line 3: The DB needs to be kept out of the repo due to Windows issues in Vagrant if it's in the repo.

Makefile: Line 5: honcho run ./manage.py is not reliable when manage.py is not executable, which can happen when using Vagrant on Windows. Using the full honcho run python ./manage.py everywhere avoids this issue. Line 9: If they are running Vagrant on Windows, line endings can be a problem here. The new code here strips off the troublesome ^M should it appear.

Procfile.dev: Line 3: We cannot expose only 127.0.0.1:5000 because the port will not be forwarded to the host in Vagrant, so we run on 0.0.0.0:5000

Vagrantfile: Line 25: Port 80 is forwarded in anticipation of production working, thought this is not yet complete.

opencraft/settings.py: Line 39: This is really a bug fix. The instructions mention that you can use a .env file, but the necessary code for reading that file was not present.

Merge request reports