Skip to content

[BIZ-2055] Fix build.

Fox Piacenti requested to merge FoxyFoxie/accounting:fox/BIZ-2055-fix-build into master

When working on the main MR for BIZ-2055, I discovered that the build was broken and has been for some time. This MR fixes the build-- resolving issues with both quality and scripts.

JIRA tickets: https://tasks.opencraft.com/browse/BIZ-2055

Screenshots: Always include screenshots if there is any change to the UI (ideally, both "before" and "after" screenshots, if applicable). If there are no UI changes, omit this.

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

Check the CI pipeline.

Author notes and concerns:

  1. Any idea why this was left broken for so long?
  2. I've had to tell the type checker to ignore several things that are relatively easy to fix in newer versions of Python. We'll want to look into circling back when we're ready to upgrade and re-review any lines with the comment type: ignore

Merge request reports