Skip to content

eliminate need for OCPI_TRANSFER_IP_ADDRESS with PTP interfaces

Robert Tracy requested to merge 1355-ext-net-interfaces into develop

What this MR does / why we need it:

This MR allows OpenCPI to use point-to-point (PTP) network connections between controlling hosts and remote platforms without having to specify both OCPI_SOCKET_INTERFACE and OCPI_TRANSFER_IP_ADDRESS, i.e., it is sufficient to specify just the socket interface. This has always been the case for normal Ethernet connections. PTP connections, e.g., VPN tunnels, are different because there's no hardware (MAC) address associated with them: thus, they are excluded from consideration by OpenCPI unless OCPI_TRANSFER_IP_ADDRESS (the local IP address associated with the PTP interface) is specified.

Steps to complete before submitting MR:

  • I have read Contribution guidelines

  • I have ensured I have a changelog written in the imperative form that is meaningful and accurately summarizes the work done

  • I have added the release notes label if applicable (more information below)

  • I have ensured the workflow labels are up to date and will continue to do so up until this work is merged into develop

  • I have added a category, type, and target release label along with all other labels as need be

  • My branch is up to date with develop. If it is not, then I have ensured my work does not conflict with other work

  • I agree my bugfix MR does not include new features/enhancements

  • I represent that bugfixes have been locally tested against the most recent major.minor release in which the bug exists

  • (REVIEWER ONLY) I have thoroughly gone through the above steps to ensure that they have been followed

Release Notes

Since this is going in as a bugfix to v2.4.X, maybe a blurb in the release announcement to the effect of the following:

It is no longer necessary to use the OCPI_TRANSFER_IP_ADDRESS workaround with point-to-point network connections between controlling hosts and remote platforms. If set, OCPI_TRANSFER_IP_ADDRESS takes precedence for such connections.

Changelog

  • bug(runtime): eliminate need for OCPI_TRANSFER_IP_ADDRESS with PTP interfaces

Which issue(s) this MR closes

Closes #1355 (closed)

Edited by Robert Tracy

Merge request reports