Skip to content

cstp: Check if uri is NULL in sso_detect_done

Passing a NULL value to strcmp is undefined behavior. Some web engines might have events where cookies are enumerated, but the event does not contain a uri enumeration. An example is QtWebEngine where it has discrete signals, QWebEngineView::urlChanged and QWebEngineCookieStore::cookieAdded. Add a check similar to the one found in gpst_sso_detect_done for the uri member of struct oc_webview_result.

Discovered this issue when implementing GlobalProtect SAML support for plasma-nm.

Signed-off-by: Rahul Rameshbabu sergeantsagara@protonmail.com

Edited by Rahul Rameshbabu

Merge request reports