Cleanup protocol-specific exceptions in install_vpn_opts()
@Rondom started a discussion:
I think adding even more crude protocol specific code into this function will not increase maintainability in the long term. In NX I added a parameter for this. 052bad06
I am also wondering why you to the add_option_dup inside
install_vpn_opts
? Is that really necessary to be done inside this function? In all other instances, we do it from the protocol code.If my patch solves your problem (please confirm), I can cherry-pick it with a slightly modified commit message and submit a merge request for that change.
(And of course I should finally submit a merge request for my NX changes. It has been a year now... :-( )
Possible cross-protocol solution path in https://gitlab.com/openconnect/openconnect/-/tree/install_vpn_opts_allow_no_ip, specifically 8d75f76c.