Skip to content

Draft: Add NiHu to cfsdeps

Luca Candussi requested to merge Candussi_NiHu into master

Description

This is the first merge request addressing #70 . The aim is to integrate the BEM Software NiHu into the CFSdeps. Currently, no changes to the testsuite made.

Testsuite merge request: ( no Testsuite changes )

Check before assigning to a maintainer for review

  • The history is clean
  • New Code is well-documented and understandable
  • There is a test case (in case of new functionality)
  • Every commit passes the pipeline

Maintainer checks before merge

  • Review is approved, and all comments are resolved
  • Check for Testsuite changes, if yes check
    • Testsuite merge request merges fast-forward
    • Testsuite-submodule SHA of every CFS commit references a commit in Testsuite Merge Request
    • Testsuite-submodule SHA of last CFS commit points to HEAD of corresponding Testsuite branch
  • Pipeline passes for every commit
    • all tests of the stage test pass
    • tests in the stage test_extra run
    • new tests are actually running (e.g. check if they appear on CDash)

Merge request reports