Skip to content

Draft: Update cgal to newest version

Patrick Heidegger requested to merge update_cgal_to_newest_version into master

Description

The cfsdeps still rely on CGAL version 3.3. This MR will update to the actual version 5.6.1.

The newer version bring up capabilities to intersect polygons in a 3D space, which I'd like to exploit in the MortarInterface class.

Also, newer versions of CGAL are header based, so it could avoid compiling issues.

We will also try to upgrade the CMAKE style to the new one, and also to get rid of all these annoying warnings that CGAL spits out in our compiling process

Testsuite merge request: ( no Testsuite changes | paste a link to the Testsuite merge request )

Check before assigning to a maintainer for review

  • The history is clean
  • New Code is well-documented and understandable
  • There is a test case (in case of new functionality)
  • Every commit passes the pipeline

Maintainer checks before merge

  • Review is approved, and all comments are resolved
  • Check for Testsuite changes, if yes check
    • Testsuite merge request merges fast-forward
    • Testsuite-submodule SHA of every CFS commit references a commit in Testsuite Merge Request
    • Testsuite-submodule SHA of last CFS commit points to HEAD of corresponding Testsuite branch
  • Pipeline passes for every commit
    • all tests of the stage test pass
    • tests in the stage test_extra run
    • new tests are actually running (e.g. check if they appear on CDash)

Merge request reports