Skip to content

Draft: Fix of hsl patching step in mac/apple-silicon build. Related to issue #97.

Description

This patch is supposed to address #97.

Proposed Changes

Adapted cfsdeps/hsl/hsl-patch.cmake.in to be able to handle releases from https://github.com/coin-or-tools/ThirdParty-HSL/releases, which provides archives in format: 2.2.2.tar.gz not coinhsl-2.2.2.tar.gz. Now it should be able to handle both correctly.

Testsuite merge request: no Testsuite changes

Check before assigning to a maintainer for review

  • The history is clean
  • New Code is well-documented and understandable
  • There is a test case (in case of new functionality)
  • Every commit passes the pipeline

Maintainer checks before merge

  • Review is approved, and all comments are resolved
  • Check for Testsuite changes, if yes check
    • Testsuite merge request merges fast-forward
    • Testsuite-submodule SHA of every CFS commit references a commit in Testsuite Merge Request
    • Testsuite-submodule SHA of last CFS commit points to HEAD of corresponding Testsuite branch
  • Pipeline passes for every commit
    • all tests of the stage test pass
    • tests in the stage test_extra run
    • new tests are actually running (e.g. check if they appear on CDash)
Edited by Richard Schreiner

Merge request reports

Loading