Fix failing OMP pipeline for 03-He-Hartree-Fock-test
All threads resolved!
All threads resolved!
Description
This MR is fixing an uninitialized variable inside an OMP region which caused the 03-He-Hartree-Fock.test to fail.
News snippet
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Closes #383 (closed)
Edited by Micael Oliveira
Merge request reports
Activity
- Resolved by Martin Lueders
added 1 commit
- 57c81fe2 - Use firstprivate for the OMP pragma to fix variable initialization.
Codecov Report
No coverage uploaded for pull request base (hotfix-10.1@4aa591d
). Click here to learn what that means. The diff coverage isn/a
.@@ Coverage Diff @@ ## hotfix-10.1 #992 +/- ## ============================================== Coverage ? 70.96% ============================================== Files ? 506 Lines ? 96789 Branches ? 0 ============================================== Hits ? 68689 Misses ? 28100 Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4aa591d...3046559. Read the comment docs.Edited by Codecov- Resolved by Sebastian Ohlmann
It may be a good idea to also fix the initialization of
aa1
,aa2
,aa3
, andaa4
for the case of the curvilinear mesh.
added 1 commit
- 3046559c - Fix reduction variable initialization also for curvilinear coordinates.
mentioned in commit 956f3894
mentioned in issue #383 (closed)
Please register or sign in to reply