Skip to content
Snippets Groups Projects

Fix failing OMP pipeline for 03-He-Hartree-Fock-test

All threads resolved!

Description

This MR is fixing an uninitialized variable inside an OMP region which caused the 03-He-Hartree-Fock.test to fail.

News snippet

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.

Closes #383 (closed)

Edited by Micael Oliveira

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 57c81fe2 - Use firstprivate for the OMP pragma to fix variable initialization.

    Compare with previous version

  • Codecov Report

    :exclamation: No coverage uploaded for pull request base (hotfix-10.1@4aa591d). Click here to learn what that means. The diff coverage is n/a.

    Impacted file tree graph

    @@              Coverage Diff               @@
    ##             hotfix-10.1     #992   +/-   ##
    ==============================================
      Coverage               ?   70.96%           
    ==============================================
      Files                  ?      506           
      Lines                  ?    96789           
      Branches               ?        0           
    ==============================================
      Hits                   ?    68689           
      Misses                 ?    28100           
      Partials               ?        0           

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aa591d...3046559. Read the comment docs.

    Edited by Codecov
  • added 1 commit

    • 3046559c - Fix reduction variable initialization also for curvilinear coordinates.

    Compare with previous version

  • Martin Lueders resolved all threads

    resolved all threads

  • Martin Lueders approved this merge request

    approved this merge request

  • Sebastian Ohlmann approved this merge request

    approved this merge request

  • Martin Lueders mentioned in commit 956f3894

    mentioned in commit 956f3894

  • Micael Oliveira changed the description

    changed the description

  • mentioned in issue #383 (closed)

  • Please register or sign in to reply
    Loading