Fix several maxwell issues
All threads resolved!
All threads resolved!
Description
Fix memory leaks and access to uninitialized variables. Also some style fixes.
News snippet
Fix several Maxwell issues
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Merge request reports
Activity
changed milestone to %11.0
added Bug + 1 deleted label
- Resolved by Micael Oliveira
@heiko.appel @fbonafe I fixed the problems flagged by valgrind in !896 (merged) Since these are all Maxwell related, I thought it would be better to fix this in a separate merge request. Please have a look to see if I my fixes are okay.
Codecov Report
Merging #926 into develop will increase coverage by
0.00%
. The diff coverage is82.35%
.@@ Coverage Diff @@ ## develop #926 +/- ## ======================================== Coverage 71.06% 71.07% ======================================== Files 507 507 Lines 98778 98807 +29 ======================================== + Hits 70194 70223 +29 Misses 28584 28584
Impacted Files Coverage Δ src/hamiltonian/hamiltonian_mxll.F90 19.14% <ø> (-0.20%)
src/hamiltonian/maxwell_boundary_op.F90 49.15% <ø> (+1.56%)
src/td/propagator_mxll.F90 20.61% <40.00%> (+0.01%)
src/hamiltonian/energy_mxll.F90 97.29% <100.00%> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a5e6952...ba04d86. Read the comment docs.Edited by Codecovmentioned in commit e37d40ad
Please register or sign in to reply