Merge poisson all dims
Description
This MR integrates the screening of the Coulomb interaction, which was implemented in X(poisson1D_solve_direct)(this, pot, rho)
into the routine subroutine poisson_solve_direct(this, pot, rho)
, eliminating the need for the extra routine. The screening is handled as an artificial extra dimension, so no additional branching has to happen in the inner loops.
News snippet
This MR integrates the screening of the Coulomb interaction, which was implemented in X(poisson1D_solve_direct)(this, pot, rho)
into the routine subroutine poisson_solve_direct(this, pot, rho)
.
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Merge request reports
Activity
changed milestone to %10.0
added Refactoring label
Codecov Report
Merging #676 into develop will increase coverage by
0.03%
. The diff coverage is54.16%
.@@ Coverage Diff @@ ## develop #676 +/- ## =========================================== + Coverage 70.83% 70.86% +0.03% =========================================== Files 472 471 -1 Lines 89536 89502 -34 =========================================== + Hits 63419 63422 +3 + Misses 26117 26080 -37
Impacted Files Coverage Δ src/poisson/poisson.F90 73.41% <50%> (+0.09%)
src/poisson/poisson_init_direct_inc.F90 69.87% <54.54%> (-0.4%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 700efaf...c0cd1b5. Read the comment docs.Edited by Codecovassigned to @micael.oliveira
mentioned in commit 9424e177
added in Changelog label