Skip to content
Snippets Groups Projects

Merge poisson all dims

Merged Martin Lueders requested to merge merge-poisson-all-dims into develop

Description

This MR integrates the screening of the Coulomb interaction, which was implemented in X(poisson1D_solve_direct)(this, pot, rho) into the routine subroutine poisson_solve_direct(this, pot, rho), eliminating the need for the extra routine. The screening is handled as an artificial extra dimension, so no additional branching has to happen in the inner loops.

News snippet

This MR integrates the screening of the Coulomb interaction, which was implemented in X(poisson1D_solve_direct)(this, pot, rho) into the routine subroutine poisson_solve_direct(this, pot, rho).

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.
Edited by Martin Lueders

Merge request reports

Pipeline #88685941 failed

Pipeline failed for c0cd1b59 on merge-poisson-all-dims

Test coverage 62.51% (-8.32%) from 0 jobs

Merged by Micael OliveiraMicael Oliveira 5 years ago (Oct 16, 2019 1:07pm UTC)

Loading

Pipeline #89217801 failed

Pipeline failed for 9424e177 on develop

Test coverage 70.71% (-8.32%) from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading