hotfix_exp_apply_taylor_psib2

Description

Bugfix: the phase was not removed for psib2 when doing the Taylor method with two times (ETRS and self-consistent ETRS).

News snippet

Bugfix: the phase was not removed for psib2 when doing the Taylor method with two times (ETRS and self-consistent ETRS).

Checklist

• I have checked that my code follows the Octopus coding standards
• I have added tests for all the new features added in this request.

changed milestone to %9.1

added Bug label

Codecov Report

No coverage uploaded for pull request base (hotfix-9.1@ea8f2da). Click here to learn what that means. The diff coverage is 100%.

@@              Coverage Diff              @@
##             hotfix-9.1     #584   +/-   ##
=============================================
  Coverage              ?   69.48%           
=============================================
  Files                 ?      458           
  Lines                 ?    86828           
  Branches              ?        0           
=============================================
  Hits                  ?    60334           
  Misses                ?    26494           
  Partials              ?        0

Impacted Files	Coverage Δ
src/system/exponential.F90	87.08% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea8f2da...b560be0. Read the comment docs.

Do you understand why the two PPC tests fail? Did they already fail before the change?

@martin.lueders Those tests were already failing. The fix is in !580 (merged).

@nicolastd No test detected this bug. We should add one.

In fact there is a good reason explaining why we did not detected this bug. At the moment, the second batch (psi2b) is only used in ETRS to get the density at t+dt, whereas psib is used to get the propagation.

However, I would still call this a bug, as the caller does not specify that psib2 can have a phase or not.

So, shall we just merge both MRs' into the hotfix-9.1 branch, or create a test first?

MR !580 (merged) is not yet ready to be merged, so it's probably better to treat this one independently.

Shall I then go ahead and merge this one (!584 (merged)) despite failing tests, knowing that it will be fixed after !580 (merged) is merged?

Knowing that the bug does not affect the results, I would simply wait for #580 to be merged.

assigned to @micael.oliveira

added 30 commits

• d63173bd...ea8f2da8 - 29 commits from branch hotfix-9.1
• b560be0b - Bugfix: the phase was not removed for psib2 when doing the Taylor method with...

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for b560be0b succeeds

merged

mentioned in commit be118a60

added in Changelog label