Skip to content
Snippets Groups Projects

Lanczos exponential: allocate batches as needed

Merged Lanczos exponential: allocate batches as needed
lanczos_automatic_order into main
All threads resolved!
Merged Sebastian Ohlmann requested to merge lanczos_automatic_order into main
All threads resolved!

Description

This removes the need of specifying TDExpOrder as the batches are allocated to the order needed, with 200 as the maximum order. This makes it much more user-friendly.

News snippet

Lanczos exponential uses automatic order, TDExpOrder not needed anymore

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.

Merge request reports

Merge request pipeline #1479684384 passed

Stage: linting
Stage: compiler_warnings
Stage: tests

Merge request pipeline passed for c275bedd

Approval is optional

Merged by Sebastian OhlmannSebastian Ohlmann 5 months ago (Oct 3, 2024 5:32pm UTC)

Merge details

  • Changes merged into with ddcd367e.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #1480715118 failed

Stage: linting
Stage: compiler_warnings
Stage: tests
Stage: build_website_content
Stage: deploy

Pipeline failed for ddcd367e on main

Deployed to ma‎in‎ 2 days ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Tancogne-Dejean
    Nicolas Tancogne-Dejean @nicolastd ·
    Owner

    @sohlmann This looks good to me. I think that this is a nice change :)

  • Nicolas Tancogne-Dejean approved this merge request

    approved this merge request

  • Sebastian Ohlmann added 1 commit

    added 1 commit

    • 343f8727 - Fix deallocation of batches in Lanczos exponential

    Compare with previous version

  • Sebastian Ohlmann added 11 commits

    added 11 commits

    • 343f8727...63e1a80d - 7 commits from branch main
    • fde09700 - Lanczos exponential: allocate batches as needed
    • b0987070 - Remove TDExpOrder from tests with Lanczos
    • 0bafddce - Adapt documentation
    • c275bedd - Fix deallocation of batches in Lanczos exponential

    Compare with previous version

    Toggle commit list
  • Sebastian Ohlmann resolved all threads

    resolved all threads

  • Sebastian Ohlmann enabled an automatic merge when all merge checks for c275bedd pass

    enabled an automatic merge when all merge checks for c275bedd pass

  • Sebastian Ohlmann merged

    merged

  • Sebastian Ohlmann mentioned in commit ddcd367e

    mentioned in commit ddcd367e

  • Martin Lueders added in Changelog label

    added in Changelog label

    • Please register or sign in to reply