Skip to content
Snippets Groups Projects

Lattice parameters in optimization.log and bugfixes

Merged Nicolas Tancogne-Dejean requested to merge optimization_log_cell into main
All threads resolved!

Description

The file optimization.log now outputs the lattice parameters for convenience.

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.
Edited by Nicolas Tancogne-Dejean

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 38c242ef - The file optimization.log now outputs the lattice parameters for convenience.

    Compare with previous version

  • added 1 commit

    • ac7ffea4 - The lattice vectors were not passed in the right order, making the minimizer do a wrong job.

    Compare with previous version

  • Nicolas Tancogne-Dejean changed title from Lattice parameters in optimization.log to Lattice parameters in optimization.log and bugfixes

    changed title from Lattice parameters in optimization.log to Lattice parameters in optimization.log and bugfixes

  • Nicolas Tancogne-Dejean marked the checklist item I have checked that my code follows the Octopus coding standards as completed

    marked the checklist item I have checked that my code follows the Octopus coding standards as completed

    • Resolved by Martin Lueders

      @martin.lueders I found another problem with the algorithm, which was preventing to relax cells: I passed the lattice vectors in a transposed order, making the implementation of FIRE (and possibly other algorithms) incompatible, as some dot products are internally done along consecutive 3 coordinates.

      This also explain why I got weird results with my 6-degrees-of-freedom version of Parrinelo-Rahman dynamics...

  • mentioned in merge request !2542 (merged)

  • Martin Lueders resolved all threads

    resolved all threads

  • Martin Lueders approved this merge request

    approved this merge request

  • added 1 commit

    • cf169aca - Automatic update of test values from testsuite app

    Compare with previous version

  • added 1 commit

    • 0cd6de10 - Automatic update of test values from testsuite app

    Compare with previous version

  • mentioned in commit cdd02cf8

  • Please register or sign in to reply
    Loading