Define minimal coupling terms as kinetic energy
Description
Define minimal coupling terms as kinetic energy and update tests
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Closes #1054 (closed)
Merge request reports
Activity
changed milestone to %14.2
added Bugfix Multisystem labels
- Resolved by Martin Lueders
@lang-m @martin.lueders do you know what's the problem with the pipeline?
changed milestone to %15.0
added 518 commits
-
4540d8cc...a155a12e - 517 commits from branch
main
- 96c9b886 - Define magnetic term as kinetic to be properly included in the electronic energy
-
4540d8cc...a155a12e - 517 commits from branch
@fbonafe Did you rebase onto main or did you merge main into your branch? The list of changes somewhow looks strange.
It looks like you are trying to add the whole gitlab-CI and CMake stuff, even though that already should be in main. Maybe we need to cherry pick the real changes of this branch. Until we figure out how to merge, please, do not merge yet.UPDATE: Ignore this comment. There seemed to be a glitch in gitlab. Now it looks fine and your RM introduces 2 changes. Once the tolerances are sorted out, this can be merged.
Edited by Martin Lueders@martin.lueders @heiko.appel this is ready to merge, as the pipeline passes.
requested review from @martin.lueders
mentioned in commit 27413644
added in Changelog label