Skip to content
Snippets Groups Projects

Fix sign of dipolar vector potential for phase

Merged Franco Bonafé requested to merge fix_phase_vecpot_sign_mxll_coupling into release-14.0
All threads resolved!

Description

Fixes sign of the dipolar vector potential coming from a Maxwell or external source system when coupling in dipole (phase). This is because the sign of the phase is written with the opposite sign. This makes the calculations in dipolar and full minimal coupling consistent.

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Buccheri resolved all threads

    resolved all threads

  • Martin Lueders mentioned in commit 9ad18e5b

    mentioned in commit 9ad18e5b

  • merged

  • Please register or sign in to reply
    Loading