Skip to content
Snippets Groups Projects

Bugfix species_full_gaussian

Merged Nicolas Tancogne-Dejean requested to merge fix_gaussian_species_threshold into release-14.0
All threads resolved!

Description

Fixes a bug introduced in 61160ad9 about the threshold of the Gaussian species root finder. This was causing the code to not find the root for the atomic density for small grid spacing.

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Tancogne-Dejean resolved all threads

    resolved all threads

  • added 1 commit

    • 9c2aed31 - Fixes a bug introduced in 61160ad9 about the threshold of the Gaussian species root finder.

    Compare with previous version

  • added 1 commit

    • 97f4f1d0 - Fixes a bug introduced in 61160ad9 about the threshold of the Gaussian species root finder.

    Compare with previous version

  • requested review from @martin.lueders

  • Martin Lueders approved this merge request

    approved this merge request

  • Martin Lueders mentioned in commit f18d7914

    mentioned in commit f18d7914

  • merged

  • Please register or sign in to reply
    Loading