Skip to content
Snippets Groups Projects

Adds the lasers to the multisystem framework

Merged Nicolas Tancogne-Dejean requested to merge laser_as_external_partner into main
All threads resolved!

Description

Adds the lasers to the multisystem framework.

The lasers are now parsed as external partners and can support the Lorentz force. The parsing is splitted such that this is compatible with generic systems.

A test is added for the Lorentz force with a charged particle.

News snippet

Adds the lasers to the multisystem framework

Checklist

  • I have checked that my code follows the Octopus coding standards
  • I have added tests for all the new features added in this request.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just one small comment, otherwise looks good.

  • added 13 commits

    Compare with previous version

  • Sebastian Ohlmann approved this merge request

    approved this merge request

  • Sebastian Ohlmann resolved all threads

    resolved all threads

  • Sebastian Ohlmann requested review from @sohlmann

    requested review from @sohlmann

  • Sebastian Ohlmann enabled an automatic merge when the pipeline for 832d935b succeeds

    enabled an automatic merge when the pipeline for 832d935b succeeds

  • Nicolas Tancogne-Dejean aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 1 commit

    • 498091b7 - Adds the lasers to the multisystem framework

    Compare with previous version

  • added 1 commit

    • 2c13e36c - Adds the lasers to the multisystem framework

    Compare with previous version

  • added 491 commits

    Compare with previous version

  • Martin Lueders changed milestone to %14.0

    changed milestone to %14.0

  • added 421 commits

    Compare with previous version

  • added 127 commits

    • 8096982a...9e8c16dd - 125 commits from branch main
    • b1de63d7 - Adds the lasers to the multisystem framework
    • 24c8fd2e - Avoids cicular dependency by introducing an enum of interactions.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 58 commits

    • 4cb9453b...38868d01 - 55 commits from branch main
    • 155186b4 - Adds the lasers to the multisystem framework
    • 1f637ffd - Avoids cicular dependency by introducing an enum of interactions.
    • 361c43fd - Fix valgrind issues.

    Compare with previous version

  • Nicolas Tancogne-Dejean resolved all threads

    resolved all threads

  • @martin.lueders I now fixed the conflict and the problem with valgrind. This should be ready to be reviewed if you have time for this.

  • added 1 commit

    Compare with previous version

  • Micael Oliveira
  • added 1 commit

    Compare with previous version

  • Micael Oliveira resolved all threads

    resolved all threads

  • Micael Oliveira approved this merge request

    approved this merge request

  • mentioned in commit 7837d1cc

  • Please register or sign in to reply
    Loading