Fix a bug in the offset of the spiral phase on GPUs.

Description

Fix a bug in the offset of the spiral phase on GPUs. The energy after the magnon kick was very different and is now much closer to the one before the kick, as it should be. It also matches the CPU energy.

News snippet

Fix a bug for the magnon kick on GPUs.

Checklist

• I have checked that my code follows the Octopus coding standards
• I have added tests for all the new features added in this request.

changed milestone to %13.0

added Bugfix label

@martin.lueders It seems that there was a problem with the kernel you wrote. This patch should fix it. Do you mind having a look to this?

added 1 commit

• af782d06 - Fix a bug in the offset of the spiral phase o GPUs.

Compare with previous version

resolved all threads

approved this merge request

Do you think this fix should still go into hotfix-12.2, or is it sufficient for the next major release?

I think that this is not used much, and we are anyway not fare from releasing 13, so I would simply leave it for the next major release.

resolved all threads

added 1 commit

• 093d91d3 - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 1 commit

• 9fb2e5cc - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 20 commits

• 9fb2e5cc...1b9d3036 - 18 commits from branch main
• 1f1b84d6 - Fix a bug in the offset of the spiral phase o GPUs.
• 695b2554 - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 43 commits

• 695b2554...adba3a65 - 41 commits from branch main
• b5b66a87 - Fix a bug in the offset of the spiral phase o GPUs.
• 3f96fb34 - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 37 commits

• 3f96fb34...6196a45d - 35 commits from branch main
• 7c246b5f - Fix a bug in the offset of the spiral phase o GPUs.
• 7715345e - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 3 commits

• 28200075 - 1 commit from branch main
• 6c5fa7cc - Fix a bug in the offset of the spiral phase o GPUs.
• 4348a9dd - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 4 commits

• 4348a9dd...94bf0fb7 - 2 commits from branch main
• 26f9927b - Fix a bug in the offset of the spiral phase o GPUs.
• 23a6db66 - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 4 commits

• 23a6db66...205812ce - 2 commits from branch main
• bc47de7c - Fix a bug in the offset of the spiral phase o GPUs.
• f93d23de - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

added 1 commit

• dc18cbe0 - Change the value of the transfered momentum to have a non-zero phase.

Compare with previous version

@martin.lueders This bugfix should be ready to be merged I think. Let me know if I need to change something or if you think it is ready to be merged.

requested review from @martin.lueders