[build-system] Fix gfortran macros
Some macros are not compatible with gfortran
built-in preprocessor. This MR aims to fix these issues.
Why do we need this
This is part of a series of fixes that would get rid of the cpp
workflow and simplify the build procedures. This is especially needed to build a simple cmake
buildchain
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Merge request reports
Activity
- Resolved by Micael Oliveira
There's a more general problem here, which is the lack of standard Fortran preprocessor. Since we aim at supporting more than gfortran, the CMake build system must also work with other compilers, like the Intel one. Any ideas how to tackle this? Also, is there a reason why we can't use cpp with CMake?
assigned to @LecrisUT
- Resolved by Micael Oliveira
Currently there is still an issue with converting the
\newline
to actual newline characters fromglobal.h
without using the perl script. If we can do that then, we can eliminatepreprocess.pl
from thecmake
workflow
- Resolved by Micael Oliveira
requested review from @micael.oliveira
added Build system label
changed milestone to %13.0
added 62 commits
-
fb8787d9...b9d5d8b2 - 60 commits from branch
octopus-code:main
- 9c30dff3 - Fix gfortran macros
- e23dfd1a - Fix compiler macros
-
fb8787d9...b9d5d8b2 - 60 commits from branch
added 46 commits
- 0a39d808 - added new sternheimer tutorial
- 4ff8cbb3 - fix some typos
- a3a31b4a - Fixing a bug for kdotp with a single electron, floating-point exceptions in...
- 088c3cf7 - The magneto-optic part is now tested on a different system than silicon cubic...
- 90a4f139 - Adjust the tolerance as one test was removed, and this influences the next one.
- 9be23544 - Increase for tolerances due to random fluctuations.
- ced5af73 - Avoid uninitialized variable. This was introduced in the previous commit.
- f37544dc - Fix another floating point exception.
- 0dd906ed - Further adjusting some tolerances.
- 31a34f8d - Fix a bug probably originating from merge conflict
- d2a738bf - added initialization of buffer
- 54d48855 - fixed wrong merg conflict resolution
- 1d4c5b69 - Remove an unused variable.
- 2dd94993 - The smearing was too large, making the tests unstable.
- 406873ac - Adjusting soem tolerances after the prior update of the pseudopotential, plus...
- ae2b1c14 - Changing the test 10-intersite.02 to be on silicon instead of graphite, which...
- ca4d05de - Remove the stringent pseudodojo sets.
- eb25cb61 - log PCM potential update only if pcm%run_pcm
- b3c1ff16 - mv debug info to after PCM potential update
- 5705af5c - moved initialization to buffer_create
- 9c861314 - revert accidental changes
- d61c7b27 - fix vtk header
- 435df5cb - fix format
- 544c0273 - fix syntax
- 2fbe755a - further shorten the notation
- 3afb95bd - Fix the vtk output for vectors in parallel
- 1dfc61a2 - Test the vtk output routine
- c4827a92 - Remove unused variables
- 7a344d94 - Removing unused modules and some small cleaning.
- 5f0b48bd - Minor fixes and cleaning to the code.
- a7c33b85 - Further minor cleaning.
- aa9c2b0c - Allow the time-imaginary evolution eigensolver to run in states parallel and...
- e5b8e70b - Changing the Poisson solver to be the same on CPUs and GPUs.
- ba411fd9 - first round of updates
- 13c86a93 - second round of updates
- 8af553f2 - third round of updates
- 18b31c3e - fourth round of updates
- e1ffc8b0 - add 2021b-builders
- 0aec88c7 - clean force tolerances
- 551f63b1 - further tweaks
- 725bdab4 - update berkeleyGW test tolerances
- d8fd89d0 - The original difference of potential could fail for post-LDA calculations in...
- c7b9a3eb - Adding a comment.
- d6d27b78 - Changing the reference value following the previous change.
- 03c3a0e4 - Fix gfortran macros
- 5fcde7db - Fix compiler macros
Toggle commit listadded 129 commits
-
5fcde7db...451d29a5 - 126 commits from branch
octopus-code:main
- 22134831 - added initialization of buffer
- 0fe66055 - Fix gfortran macros
- 86147a84 - Fix compiler macros
Toggle commit list-
5fcde7db...451d29a5 - 126 commits from branch
added 2 commits
mentioned in commit b2206c3e
@LecrisUT Going in! Thanks for the patience.