Resolve "Fix tests for Maxwell with linear medium"
All threads resolved!
All threads resolved!
Description
Update test values and tolerances for Maxwell tests 03-linear-medium and 04-linear-medium-from-file.
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Closes #430 (closed)
Merge request reports
Activity
changed milestone to %11.0
added Bugfix label
Codecov Report
Merging #1109 (ef5807cf) into develop (97e1e15d) will decrease coverage by
0.76%
. The diff coverage is83.33%
.@@ Coverage Diff @@ ## develop #1109 +/- ## =========================================== - Coverage 71.30% 70.53% -0.77% =========================================== Files 515 515 Lines 100042 102726 +2684 =========================================== + Hits 71332 72458 +1126 - Misses 28710 30268 +1558
Impacted Files Coverage Δ src/maxwell/medium_mxll.F90 87.03% <83.33%> (+2.42%)
src/sternheimer/em_resp_calc_inc.F90 65.75% <0.00%> (-14.25%)
src/electrons/eigensolver_inc.F90 88.88% <0.00%> (-11.12%)
src/basis_set/orbitalset_inc.F90 75.44% <0.00%> (-8.56%)
src/states/states_elec_parallel.F90 78.31% <0.00%> (-8.18%)
src/electrons/xc_oep_qed_inc.F90 92.66% <0.00%> (-7.34%)
src/grid/par_vec_inc.F90 87.14% <0.00%> (-6.71%)
src/sternheimer/em_resp_inc.F90 80.35% <0.00%> (-6.36%)
src/hamiltonian/lda_u_inc.F90 77.70% <0.00%> (-5.63%)
src/output/output_h_inc.F90 49.40% <0.00%> (-5.57%)
... and 311 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 97e1e15...ef5807c. Read the comment docs.Edited by Codecovadded 4 commits
- f56ada25 - Increase medium box size by 0.1% in test 03-medium-box, this does not change test values
- 0c530d46 - Increase cube sides in off file by 0.1% and replace test values in...
- 7a28b47b - Add match for total number of points for test 04-linear-medium-from-file
- ce951881 - Fix output of linear medium points number by doing MPI reduce
Toggle commit list- Resolved by Heiko Appel
assigned to @heiko.appel
added 1 commit
- ef5807cf - Add else statement for correct definition of global_points_number in serial compilation
mentioned in commit 69d74f97
Please register or sign in to reply