Skip to content

In errors, store chunk ids as `ChunkId`, not `String`

Alexander Batischev requested to merge Minoru-kun/obnam:feature/114-replace-string-with-chunkid into main

Fixes #114 (closed).

I looked through remaining uses of String (not just in error types, but in the entire codebase). It looks like most of them are legitimate strings, with two exceptions:

  1. we often represent generations as strings. Aren't generations identified by their ChunkId?
  2. we represent checksums as Strings with hexadecimal number.

Might be worthwhile to introduce separate types for those, but I don't understand the architecture well enough to judge.

Merge request reports