Skip to content

Upgrade rubocop to version 0.59.1

Peter Boling requested to merge depfu/update/rubocop-0.59.1 into master

Created by: depfu[bot]

We've upgraded a dependency and all tests pass. \o/

name version specification new version
rubocop ~> 0.58.0 0.59.1

You should probably take a good look at this before merging this pull request, of course.

What changed?

✳️ rubocop ( → 0.59.1) · Repo · Changelog

Release Notes

0.59.1

Bug fixes

  • #6267: Fix undefined method 'method_name' for Rails/FindEach. (@Knack)
  • #6278: Fix false positive for Naming/FileName when investigating gemspecs. (@kddeisz)
  • #6256: Fix false positive for Naming/FileName when investigating dotfiles. (@sinsoku)
  • #6242: Fix Style/EmptyCaseCondition auto-correction removes comment between case and first when. (@koic)
  • #6261: Fix undefined method error for Style/RedundantBegin when calling super with a block. (@eitoball)
  • #6263: Fix an error Layout/EmptyLineAfterGuardClause when guard clause is after heredoc including string interpolation. (@koic)
  • #6281: Fix false negative in Style/MultilineMethodSignature. (@drenmi)
  • #6264: Fix an incorrect autocorrect for Layout/EmptyLineAfterGuardClause cop when if condition is after heredoc. (@koic)

Changes

  • #6272: Make Lint/UnreachableCode detect exit, exit! and abort. (@hoshinotsuyoshi)
  • #6295: Exclude #=== from Naming/BinaryOperatorParameterName. (@zverok)
  • Add + to allowed file names of Naming/FileName. (@yensaki)

0.59.0

New features

  • #6109: Add new Bundler/GemComment cop. (@sunny)
  • #6148: Add IgnoredMethods option to Style/NumericPredicate cop. (@AlexWayfer)
  • #6174: Add --display-only-fail-level-offenses to only output offenses at or above the fail level. (@robotdana)
  • Add autocorrect to Style/For. (@rrosenblum)
  • #6173: Add AllowImplicitReturn option to Rails/SaveBang cop. (@robotdana)
  • #6218: Add comparison style to Style/NilComparison. (@khiav223577)
  • Add new Style/MultilineMethodSignature cop. (@drenmi)
  • #6234: Add Performance/ChainArrayAllocation cop. (@schneems)
  • #6136: Add remote url in remote url download error message. (@ShockwaveNN)
  • #5659: Make Layout/EmptyLinesAroundClassBody aware of specifying a superclass that breaks the line. (@koic)

Bug fixes

  • #6107: Fix indentation of multiline postfix conditionals. (@jaredbeck)
  • #6140: Fix Style/DateTime not detecting #to_datetime. It can be configured to allow this. (@bdewater)
  • #6132: Fix a false negative for Naming/FileName when Include of AllCops is the default setting. (@koic)
  • #4115: Fix false positive for unary operations in Layout/MultilineOperationIndentation. (@jonas054)
  • #6127: Fix an error for Layout/ClosingParenthesisIndentation when method arguments are empty with newlines. (@tatsuyafw)
  • #6152: Fix a false negative for Layout/AccessModifierIndentation when using access modifiers with arguments within nested classes. (@gmalette)
  • #6124: Fix Style/IfUnlessModifier cop for disabled Layout/Tab cop when there is no IndentationWidth config. (@AlexWayfer)
  • #6133: Fix AllowURI option of Metrics/LineLength cop for files with tabs indentation. (@AlexWayfer)
  • #6164: Fix incorrect autocorrect for Style/UnneededCondition when using operator method higher precedence than ||. (@koic)
  • #6138: Fix a false positive for assigning a block local variable in Lint/ShadowedArgument. (@jonas054)
  • #6022: Fix Layout/MultilineHashBraceLayout and Layout/MultilineArrayBraceLayout auto-correct syntax error when there is a comment on the last element. (@bacchir)
  • #6175: Fix Style/BracesAroundHashParameters auto-correct syntax error when there is a trailing comma. (@bacchir)
  • #6192: Make Style/RedundantBegin aware of stabby lambdas. (@drenmi)
  • #6208: Ignore assignment methods in Naming/PredicateName. (@sunny)
  • #6196: Fix incorrect autocorrect for Style/EmptyCaseCondition when using return in when clause and assigning the return value of case. (@koic)
  • #6142: Ignore keyword arguments in Rails/Delegate. (@sunny)
  • #6240: Fix an auto-correct error for Style/WordArray when setting EnforcedStyle: brackets and using string interpolation in %W literal. (@koic)
  • #6202: Fix infinite loop when auto-correcting Lint/RescueEnsureAlignment when end is misaligned. The alignment and message are now based on the beginning position rather than the end position. (@rrosenblum)
  • #6199: Don't recommend Date usage in Style/DateTime. (@deivid-rodriguez)

Changes

  • #6161: Add scope methods to Rails/FindEach cop. Makes the cop also check for the following scopes: eager_load, includes, joins, left_joins, left_outer_joins, preload, references, and unscoped. (@repinel)
  • #6137: Allow db to allowed names of Naming/UncommunicativeMethodParamName cop in default config. (@mkenyon)
  • Update the highlighting of Lint/DuplicateMethods to include the method name. (@rrosenblum)
  • #6057: Return 0 when running rubocop --auto-gen-conf if the todo file is successfully created even if there are offenses. (@MagedMilad)
  • #4301: Turn off autocorrect for Rails/RelativeDateConstant by default. (@koic)
  • #4832: Change the path pattern (*) to match the hidden file. (@koic)
  • Style/For now highlights the entire statement rather than just the keyword. (@rrosenblum)
  • Disable Performance/CaseWhenSplat and its auto-correction by default. (@rrosenblum)
  • #6235: Enable Layout/EmptyLineAfterGuardClause cop by default. (@koic)
  • #6199: Style/DateTime has been moved to disabled by default. (@deivid-rodriguez)

0.58.2

Changes

New features

  • #6105: Support {a,b} file name globs in Exclude and Include config. (@mikeyhew)

  • #6116: Add ip to allowed names of Naming/UncommunicativeMethodParamName cop in default config. (@nijikon)

Bug fixes

  • #6103: Fix a false positive for Layout/IndentationWidth when multiple modifiers are used in a block and a method call is made at end of the block. (@koic)
  • #6084: Fix Naming/MemoizedInstanceVariableName cop to allow methods to have leading underscores. (@kenman345)
  • #6098: Fix an error for Layout/ClassStructure when there is a comment in the macro method to be auto-correct. (@koic)
  • #6115: Fix a false positive for Lint/OrderedMagicComments when using { encoding: Encoding::SJIS } hash object after frozen_string_literal magic comment. (@koic)

0.58.1

Bug fixes

  • #6071: Fix auto-correct Style/MethodCallWithArgsParentheses when arguments are method calls. (@maxh)
  • Fix Style/RedundantParentheses with hash literal as first argument to super. (@maxh)
  • #6086: Fix an error for Gemspec/OrderedDependencies when using method call to gem names in gemspec. (@koic)
  • #6089: Make Rails/BulkChangeTable aware of variable table name. (@wata727)
  • #6088: Fix an error for Layout/MultilineAssignmentLayout cop when using multi-line block defines on separate lines. (@koic)
  • #6092: Don't use the broken parser 2.5.1.1 version. (@bbatsov)

0.57.2

Bug fixes

  • #5968: Prevent Layout/ClosingHeredocIndentation from raising an error on << heredocs. (@dvandersluis)
  • #5965: Prevent Layout/ClosingHeredocIndentation from raising an error on heredocs containing only a newline. (@drenmi)
  • Prevent a crash in Layout/IndentationConsistency cop triggered by an empty expression string interpolation. (@alexander-lazarov)
  • #5951: Prevent Style/MethodCallWithArgsParentheses from raising an error in certain cases. (@drenmi)

0.57.1

Bug fixes

  • #5963: Allow Performance/ReverseEach to apply to any receiver. (@dvandersluis)
  • #5917: Fix erroneous warning for inherit_mode directive. (@jonas054)
  • #5380: Fix false negative in Layout/IndentationWidth when an access modifier section has an invalid indentation body. (@tatsuyafw)
  • #5909: Even when a module has no public methods, Layout/IndentationConsistency should still register an offense for private methods. (@jaredbeck)
  • #5958: Handle empty method body in Rails/BulkChangeTable. (@wata727)
  • #5954: Make Style/UnneededCondition cop accepts a case of condition and if_branch are same when using elsif branch. (@koic)

0.57.0

New features

  • #5881: Add new Rails/BulkChangeTable cop. (@wata727)
  • #5444: Add new Style/AccessModifierDeclarations cop. (@brandonweiss)
  • #5803: Add new Style/UnneededCondition cop. (@balbesina)
  • #5406: Add new Layout/ClosingHeredocIndentation cop. (@siggymcfried)
  • #5823: Add new slashes style to Rails/FilePath since Ruby accepts forward slashes even on Windows. (@sunny)
  • New cop Layout/LeadingBlankLines checks for empty lines at the beginning of a file. (@rrosenblum)

Bug fixes

  • #5897: Fix Style/SymbolArray and Style/WordArray not working on arrays of size 1. (@TikiTDO)
  • #5894: Fix Rails/AssertNot to allow it to have failure message. (@koic)
  • #5888: Do not register an offense for headers or env keyword arguments in Rails/HttpPositionalArguments. (@rrosenblum)
  • Fix the indentation of autocorrected closing squiggly heredocs. (@garettarrowood)
  • #5908: Fix Style/BracesAroundHashParameters auto-correct going past the end of the file when the closing curly brace is on the last line of a file. (@EiNSTeiN-)
  • Fix a bug where Style/FrozenStringLiteralComment would be added to the second line if the first line is empty. (@rrosenblum)
  • #5914: Make Layout/SpaceInsideReferenceBrackets aware of no_space when using nested reference brackets. (@koic)
  • #5799: Fix false positive in Style/MixinGrouping when method named include accepts block. (@Darhazer)

Changes

0.56.0

New features

  • #5848: Add new Performance/InefficientHashSearch cop. (@JacobEvelyn)
  • #5801: Add new Rails/RefuteMethods cop. (@koic)
  • #5805: Add new Rails/AssertNot cop. (@composerinteralia)
  • #4136: Allow more robust Layout/ClosingParenthesisIndentation detection including method chaining. (@jfelchner)
  • #5699: Add consistent_relative_to_receiver style option to Layout/FirstParameterIndentation. (@jfelchner)
  • #5821: Support AR::Migration#up_only for Rails/ReversibleMigration cop. (@koic)
  • #5800: Don't show a stracktrace for invalid command-line params. (@shanecav84)
  • #5845: Add new Lint/ErbNewArguments cop. (@koic)
  • #5871: Add new Lint/SplatKeywordArguments cop. (@koic)
  • #4247: Remove hard-coded file patterns and use only Include, Exclude and the new RubyInterpreters parameters for file selection. (@jonas054)

Bug fixes

  • Fix bug in Style/EmptyMethod which concatenated the method name and first argument if no method def parentheses are used. (@thomasbrus)
  • #5819: Fix Rails/SaveBang when using negated if. (@Edouard-chin)
  • #5286: Fix Lint/SafeNavigationChain not detecting chained operators after block. (@Darhazer)
  • Fix bug where Lint/SafeNavigationConsistency registers multiple offenses for the same method call. (@rrosenblum)
  • #5713: Fix Style/CommentAnnotation reporting only the first of multiple consecutive offending lines. (@svendittmer)
  • #5791: Fix exception in Lint/SafeNavigationConsistency when there is code around the condition. (@rrosenblum)
  • #5784: Fix a false positive for Rails/HasManyOrHasOneDependent when using nested with_options. (@koic)
  • #4666: --stdin always treats input as Ruby source irregardless of filename. (@PointlessOne)
  • Fix auto-correction for Style/MethodCallWithArgsParentheses adding extra parentheses if the method argument was already parenthesized. (@dvandersluis)
  • #5668: Fix an issue where files with unknown extensions, listed in AllCops/Include were not inspected when passing the file name as an option. (@drenmi)
  • #5809: Fix exception Lint/PercentStringArray and Lint/PercentSymbolArray when the inspected file is binary encoded. (@akhramov)
  • #5840: Do not register an offense for methods that nil responds to in Lint/SafeNavigationConsistency. (@rrosenblum)
  • #5862: Fix an incorrect auto-correct for Lint/LiteralInInterpolation if contains numbers. (@koic)
  • #5868: Fix Rails/CreateTableWithTimestamps when using hash options. (@wata727)
  • #5708: Fix exception in Lint/UnneededCopEnableDirective for instruction '# rubocop:enable all'. (@balbesina)
  • Fix auto-correction of Rails/HttpPositionalArgumnets to use session instead of header. (@rrosenblum)

Changes

  • Split Style/MethodMissing into two cops, Style/MethodMissingSuper and Style/MissingRespondToMissing. (@rrosenblum)
  • #5757: Add AllowInMultilineConditions option to Style/ParenthesesAroundCondition cop. (@Darhazer)
  • #5806: Fix Layout/SpaceInsideReferenceBrackets when assigning a reference bracket to a reference bracket. (@joshuapinter)
  • #5082: Allow caching together with --auto-correct. (@jonas054)
  • Add try! to the list of whitelisted methods for Lint/SafeNavigationChain and Style/SafeNavigation. (@rrosenblum)
  • #5886: Move Style/EmptyLineAfterGuardClause cop to Layout department. (@koic)

0.55.0

New features

Bug fixes

  • #5759: Fix Performance/RegexpMatch cop not correcting negated match operator. (@bdewater)
  • #5726: Fix false positive for :class_name option in Rails/InverseOf cop. (@bdewater)
  • #5686: Fix a regression for Style/SymbolArray and Style/WordArray for multiline Arrays. (@istateside)
  • #5730: Stop Rails/InverseOf cop allowing inverse_of: nil to opt-out. (@bdewater)
  • #5561: Fix Lint/ShadowedArgument false positive with shorthand assignments. (@akhramov)
  • #5403: Fix Naming/HeredocDelimiterNaming blacklist patterns. (@mcfisch)
  • #4298: Fix auto-correction of Performance/RegexpMatch to produce code that safe guards against the receiver being nil. (@rrosenblum)
  • #5738: Make Rails/HttpStatus ignoring hash order to fix false negative. (@pocke)
  • #5720: Fix false positive for Style/EmptyLineAfterGuardClause when guard clause is after heredoc. (@koic)
  • #5760: Fix incorrect offense location for Style/EmptyLineAfterGuardClause when guard clause is after heredoc argument. (@koic)
  • #5764: Fix Style/Unpackfirst false positive of unpack('h*').take(1). (@parkerfinch)
  • #5766: Update Style/FrozenStringLiteralComment auto-correction to insert a new line between the comment and the code. (@rrosenblum)
  • #5551: Fix Lint/Void not detecting void context in blocks with single expression. (@Darhazer)

Changes

  • #5752: Add String#delete_{prefix,suffix} to Lint/Void cop. (@bdewater)
  • #5734: Add by, on, in and at to allowed names of Naming/UncommunicativeMethodParamName cop in default config. (@AlexWayfer)
  • #5666: Add spaces as an EnforcedStyle option to Layout/SpaceInsideParens, allowing you to enforce spaces inside of parentheses. (@joshuapinter)
  • #4257: Allow specifying module name in Metrics/BlockLength's ExcludedMethods configuration option. (@akhramov)
  • #4753: Add IgnoredMethods option to Style/MethodCallWithoutArgsParentheses cop. (@Darhazer)
  • #4517: Add option to allow trailing whitespaces inside heredoc strings. (@Darhazer)
  • #5652: Make Style/OptionHash aware of implicit parameter passing to super. (@Wei-LiangChew)
  • #5451: When using --auto-gen-config, do not ouput offenses unless the --output-offenses flag is also passed. (@drewpterry)

0.54.0

New features

Bug fixes

  • #5683: Fix message for Naming/UncommunicativeXParamName cops. (@jlfaber)
  • #5680: Fix Layout/ElseAlignment for rescue/else/ensure inside do/end blocks. (@YukiJikumaru)
  • #5642: Fix Style/Documentation :nodoc: for compact-style nested modules/classes. (@ojab)
  • #5648: Suggest valid memoized instance variable for predicate method. (@satyap)
  • #5670: Suggest valid memoized instance variable for bang method. (@pocke)
  • #5623: Fix Bundler/OrderedGems when a group includes duplicate gems. (@colorbox)
  • #5633: Fix broken --fail-fast. (@mmyoji)
  • #5630: Fix false positive for Style/FormatStringToken when using placeholder arguments in format method. (@koic)
  • #5651: Fix NoMethodError when specified config file that does not exist. (@onk)
  • #5647: Fix encoding method of RuboCop::MagicComment::SimpleComment. (@htwroclau)
  • #5619: Do not register an offense in Style/InverseMethods when comparing constants with <, >, <=, or >=. If the code is being used to determine class hierarchy, the correction might not be accurate. (@rrosenblum)
  • #5641: Disable Style/TrivialAccessors auto-correction for def with private. (@pocke)
  • Fix bug where Style/SafeNavigation does not auto-correct all chained methods resulting in a Lint/SafeNavigationChain offense. (@rrosenblum)
  • #5436: Allow empty kwrest args in UncommunicativeName cops. (@pocke)
  • #5674: Fix auto-correction of Layout/EmptyComment when the empty comment appears on the same line as code. (@rrosenblum)
  • #5679: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before rescue or ensure. (@koic)
  • #5694: Match Rails versions with multiple digits when reading the TargetRailsVersion from the bundler lock files. (@roberts1000)
  • #5700: Fix a false positive for Style/EmptyLineAfterGuardClause when guard clause is before else. (@koic)
  • Fix false positive in Naming/ConstantName when using conditional assignment. (@drenmi)

Changes

  • #5626: Change Naming/UncommunicativeMethodParamName add to to allowed names in default config. (@unused)
  • #5640: Warn about user configuration overriding other user configuration only with --debug. (@jonas054)
  • #5637: Fix error for Layout/SpaceInsideArrayLiteralBrackets when contains an array literal as an argument after a heredoc is started. (@koic)
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. (@hamada14)
  • #5610: Use gems.locked or Gemfile.lock to determine the best TargetRubyVersion when it is not specified in the config. (@roberts1000)
  • #5390: Allow exceptions to Style/InlineComment for inline comments which enable or disable rubocop cops. (@jfelchner)
  • Add progress bar to offenses formatter. (@drewpterry)
  • #5498: Correct IndentHeredoc message for Ruby 2.3 when using <<~ operator with invalid indentation. (@hamada14)

Not all release notes shown. View the full release notes

Commits

See the full diff on Github. The new version differs by 38 commits:

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

Depfu Status

Merge request reports