Skip to content
Snippets Groups Projects

Draft: Compat with golang 1.17

Closed Draft: Compat with golang 1.17
golang-1.17-compat into main
1 unresolved thread
Closed Evan Lezar requested to merge golang-1.17-compat into main
1 unresolved thread

Some customers need to build the components of the NVIDIA Container Toolkit from source using Golang 1.17.

This MR defines some minor change that allow the project to be built using Go 1.17, with an internal/errors package being used to provide basic errors.Join functionality. This is the only feature we currently use from Go 1.20.

Signed-off-by: Evan Lezar elezar@nvidia.com

Edited by Evan Lezar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
docker/Dockerfile.devel
16 16 FROM golang:${GOLANG_VERSION}
17 17
18 18 RUN go install golang.org/x/lint/golint@6edffad5e6160f5949cdefc81710b2706fbcd4f6
19 RUN go install github.com/matryer/moq@latest
19 # RUN go install github.com/matryer/moq@latest
  • Ian Stewart
    Ian Stewart @stewart.ib ·

    Is this related to this change?

  • Evan Lezar
    Evan Lezar @elezar ·
    Author Owner

    The latest version of moq doesn't work under go1.17, so this would have to be dependent on the GOLANG version.

    Note that this tooling is only used to generate mock implementations of an interface and is not a build dependency.

  • Please register or sign in to reply
  • Ian Stewart
    Ian Stewart @stewart.ib ·

    Looks great, thanks again!

  • Evan Lezar
    Evan Lezar @elezar ·
    Author Owner

    Migrated to https://github.com/NVIDIA/nvidia-container-toolkit/pull/337

  • Evan Lezar closed

    closed

    • Please register or sign in to reply