Skip to content

tcp: fix assertion failure in tx-buffer when SACK is disabled and loss rate is high

Xiuchao Wu requested to merge xiuchao/ns-3-dev:tcp-assertion-failure-wosack into master

tcp-tx-buffer is designed to work no matter whether SACK is enabled. However, when SACK is disabled and packet loss rate is high, m_sentList could have only one packet when AddRenoSack() is called. Hence, the assertion at the beginning of TcpTxBuffer::AddRenoSack() will fail. The bug-fix explicitly let tcp-tx-buffer know whether SACK is enabled on the corresponding TCP socket and relax the assertion if SACK is disabled.

Merge request reports