Skip to content

Move the code to check the intersection between a line segment and a box to the Box class

ZorazeAli requested to merge ZorazeAli/ns-3-dev:box-line-intersection into master

This merge request proposes the following improvements:

  1. For the sake of clarity, the method IsWithinLineOfSight of BuildingsChannelConditionModel class is renamed to IsLineOfSightBlocked. The word WithIn in the previous name is a bit confusing for me since I didn't understand if it refers to the building or the two positions.

  2. The code for checking the intersection between a line segment and a box is moved to the Box class. This code is very general and could be used by other classes as well, e.g., other propagation models or mobility models [!125 (closed)]. The following diagram shows the new flow. isintersect

Please let me know what you think. Also including @mychele and @tommasozugno.

Merge request reports