Move the code to check the intersection between a line segment and a box to the Box class
This merge request proposes the following improvements:
-
For the sake of clarity, the method
IsWithinLineOfSight
ofBuildingsChannelConditionModel
class is renamed toIsLineOfSightBlocked
. The wordWithIn
in the previous name is a bit confusing for me since I didn't understand if it refers to the building or the two positions. -
The code for checking the intersection between a line segment and a box is moved to the
Box
class. This code is very general and could be used by other classes as well, e.g., other propagation models or mobility models [!125 (closed)]. The following diagram shows the new flow.
Please let me know what you think. Also including @mychele and @tommasozugno.