Skip to content

internet: Fix tcp flags check to determine packet type

Gabriel Ferreira requested to merge Gabrielcarvfer/ns-3-dev:FixTcpPacketTypeAckPlusEce into master

(TcpHeader::ACK | TcpHeader::ECE) was not correctly tested, resulting in an uninitialized packetType value.

Optimization hid the bug, and for some reason, valgrind didn't catch it. EDIT: It actually did. See https://gitlab.com/nsnam/ns-3-dev/-/jobs/8000130004

I ask TCP experts give this a look. Also, there can be an ACK + RST. Should that be classified as a PURE_ACK, RST, or should be a new RST_ACK, following the existing SYN_ACK.

Edited by Gabriel Ferreira

Merge request reports