clang-tidy: Remove check readability-uppercase-literal-suffix
requested to merge edalm/ns-3-dev:clang-tidy-remove-readability-uppercase-literal-suffix into master
Remove the clang-tidy check readability-uppercase-literal-suffix. This check enforces the convention of declaring literal suffixes in uppercase (i.e., float x = 5.0F;)
Clang-tidy now provides a profiling option that measures the time taken by each check. This check proved to be very heavy and with no real benefit. In a total of 30 minutes taken by clang-tidy, this check lasted for 2 minutes.
Therefore, I propose to remove it.
PS: I'm working on a script to perform this measurement automatically. I will share it in the future.