Skip to content

Draft: Replace always-false asserts with `NS_FATAL_ERROR()` and add job to CI

Eduardo Almeida requested to merge edalm/ns-3-dev:fix-assert-conditions into master

Replace always-false asserts (i.e., NS_ASSERT(false, ...)) with NS_FATAL_ERROR(), which makes the code more readable. Update the coding style guide with this recommendation and add a CI job a new check to check-style-clang-format.py to detect and prevent these cases in the future.

I tried to add meaningful messages to the asserts based on the surrounding context, but they might be improved. I would ask module owners to please check if they make sense and suggest improvements, if necessary.

TO DO:

  • Replace the CI job by a new check in check-style-clang-format.py.
Edited by Eduardo Almeida

Merge request reports