Skip to content

test: Multiple improvements to test.py and removal of utils.py

Eduardo Almeida requested to merge edalm/ns-3-dev:python-test-improvements into master

Multiple improvements to test.py script, namely:

  • General code simplifications.
  • Use subprocess.run() instead of subprocess.Popen().
  • Use ast.literal_eval() instead of eval(), which is less safe.
  • Remove Python2 fallback when importing queue package. !1675 (merged)

Moreover, the file utils.py contains three functions, but only the function get_list_from_file() is currently used. Therefore, move the that function to the script test.py, where it is used.

Edited by Eduardo Almeida

Merge request reports