Skip to content
Snippets Groups Projects

Add length field to Bytes and String layout

Open Peter Duchovni requested to merge archaephyrryx/data-encoding:enrich-layout into master

Annotate Bytes and String variants of the binary_description type layout with Encoding.Kind.length parameters in order to preserve fixed-length information when used as internal layout of a Seq encoding (List or Array).

[Fix for bug noted in issue #26 ]

[Rebased onto test case addition !48 (closed) ]

Edited by Peter Duchovni

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think that further changes are needed in order to carry the information all the way to the printing part. I'm guessing the pretty-printer for the layout needs to mention the size of the strings/bytes. I'm not sure if it needs anything else.

  • Peter Duchovni added 1 commit

    added 1 commit

    • c035eee0 - Add length field to Bytes and String layout

    Compare with previous version

  • Peter Duchovni resolved all threads

    resolved all threads

  • Peter Duchovni added 4 commits

    added 4 commits

    Compare with previous version

  • Peter Duchovni added 17 commits

    added 17 commits

    Compare with previous version

  • Peter Duchovni mentioned in merge request !48 (closed)

    mentioned in merge request !48 (closed)

  • Peter Duchovni added 10 commits

    added 10 commits

    Compare with previous version

  • Peter Duchovni added 4 commits

    added 4 commits

    • a0ec34b2 - Apply 1 suggestion(s) to 1 file(s)
    • b7618bde - Extend fixed_seq test cases
    • 891a8cbd - Autoformat for CI
    • d017b058 - Add length field to Bytes and String layout

    Compare with previous version

  • Peter Duchovni changed the description

    changed the description

  • Peter Duchovni added 1 commit

    added 1 commit

    • c705c290 - Add length field to Bytes and String layout

    Compare with previous version

  • Peter Duchovni added 5 commits

    added 5 commits

    • c705c290...ddc68273 - 3 commits from branch nomadic-labs:master
    • 1f7aea9c - Test: add test for fixed-length sequence elem bug
    • 91289618 - Add length field to Bytes and String layout

    Compare with previous version

  • Peter Duchovni added 3 commits

    added 3 commits

    • c30aecc3 - Test: add test for fixed-length sequence elem bug
    • c9f76444 - Add length field to Bytes and String layout
    • 81c52364 - ocamlformat: auto-promote

    Compare with previous version

  • Raphaël Proust added 6 commits

    added 6 commits

    • 81c52364...ab152bb7 - 3 commits from branch nomadic-labs:master
    • 5c705b61 - Test: add test for fixed-length sequence elem bug
    • c486ee4e - Add length field to Bytes and String layout
    • e6f923d7 - ocamlformat: auto-promote

    Compare with previous version

  • Raphaël Proust added 9 commits

    added 9 commits

    • e6f923d7...1c073b8b - 6 commits from branch nomadic-labs:master
    • adb898fd - Test: add test for fixed-length sequence elem bug
    • 10288c7a - Add length field to Bytes and String layout
    • fc3706e8 - ocamlformat: auto-promote

    Compare with previous version

  • pietro requested review from @yrg

    requested review from @yrg

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading