Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • G gnunet-docker
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nikolaus Hammerschmied
  • gnunet-docker
  • Merge requests
  • !1

Refactor python code, build gnunetrest docker image and test it with an external gnunet image

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open juga requested to merge juga0/gnunet-docker:refactor into master Nov 04, 2020
  • Overview 16
  • Commits 28
  • Pipelines 4
  • Changes 14

This is the branch in which i told you i was beautifying your code :) I replaced your example file by proper tests. I also removed the gnunet docker creation since those sources should be in gnunet repo and we can just use it. And i'm now also building an image and container only with the gnunet rest stuff, to be able to test it together with the gnunet container.

You can pull the same image that gitlab builds from https://gitlab.com/juga0/gnunet-docker/container_registry

I've left intentionally python tests that do not pass. I don't why, but we should fix them. In gitlab pipeline, you can see tests not passing here: https://gitlab.com/juga0/gnunet-docker/-/jobs/830242316#L814, You can see the tests not passing locally, either by running docker-compose up, or launching a gnunet container exposing to your host the rest port and running inside of the python code pytest-3 tests (or pytest if you're in a virtualenv).

I'd recommend you look at the changes commit by commit, since they're quite a lot.

Ask me anything isn't clear ;)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor