Adding iperf3 support for TCP flows
Fixing issue #58 (closed) and is a derivative of !160 (closed)
Merge request reports
Activity
requested review from @DhanaSekharM
@geegatomar - the pipeline has failed. Please check and fix the issues.
added 1 commit
- 152800dc - run_exp.py: Allowing multiple server runners with varied protocols
added 8 commits
- 6d471ca7 - Updating ss support of iperf3 with tcp
- 3f8f5e1c - Updating the iperf3 plotter filename
- bf3767fc - Adding iperf3 support for TCP
- b537d6de - experiment.py linter error fix
- 0fc0a617 - ss.py : linter error fix
- 21e5131f - Allowing server runners with varied protocols
- b802db82 - experiment.py: Fixing type error
- 20231601 - iperf3.py : formatting error fixes
Toggle commit list213 243 self.flows.append(copy.deepcopy(flow)) 214 244 215 245 @input_validator 216 def add_tcp_flow(self, flow: Flow, congestion_algorithm="cubic"): 246 def add_tcp_flow( 247 self, 248 flow: Flow, 249 congestion_algorithm="cubic", 250 tool="netperf", 251 specs: Iperf3Specs = Iperf3Specs(), @DhanaSekharM so if we are using
kwargshere, do we need to useIperfSpecsClass ? It will be just like creating an intermediate variable and reassigning of values. We could just update theoptions,user_optionsdirectly usingkwargsonly instead of assigning values tospecsand then using it. Something like:options.update({"target_bw": kwargs.setdefault("target_bandwidth","1mbit")})Have pushed the changes in the MR please look into it
Edited by Riya Shahchanged this line in version 8 of the diff
- Resolved by Shivangi Tomar
Please add testcases for this feature as well. You can use the existing testcases as reference.
- Last reply by Shivangi Tomar
added 1 commit
- 26e75cc0 - experiment.py: adding kwargs to add_tcp_flow
-
Thanks @geegatomar - can you also update the commit messages by adding the name of the module as a prefix to the commit message? For example, if the commit message is related to the experiment module, we typically give the commit message as "experiment: ...."
Sure, Done.
Edited by Shivangi Tomar
