Resolve "Unify NNG binding crate with Runng"
Closes #17 (closed), #27 (closed)
Closes #24 (closed) and #6 (closed) via !30 (merged)
Currently waiting on the new nng-sys crate to be ready. At the time of writing, that is just a matter of closing one issue, waiting for the next NNG version, and then agreeing that it is ready.
Outstanding Items
-
Should the AIO types be different? No The cleanup made it fairly clear as to what the issues were and it might actually make sense for them to be a single type.- The issue largely revolves around the ownership of the message inside the AIO object. Either the
AioResult
type needs to haveOption<Message>
resulting in annoying calls tounwrap
, or we will have to make copies of the message which is inefficient and adds a significant amount of complexity to tracking the lifetime of the message. - Actually, the waiting AIO object really just shouldn't exist at all. See the "discussion" in #24 (closed).
-
Come up with better names for the new AIO types. -
Complete the CHANGELOG. -
Run Rustfmt.
Edited by Nathan Kent