User/dgc/guilt/warnings
Clean out warnings on my Ubuntu 18.04 system.
These should all be NFC changesets. In some cases we take a slightly different strategy; in others we just assign a return code and evaluate it. (The compiler also doesn't like unused variables.)
The only point here is to use the simplest code that doesn't produce warnings under glibc's warn_unused_result
attributes. See individual commit log messages for some other details.