Skip to content

RFC: Expose get_engine

Pablo Lorenzatto requested to merge expose_get_engine into master

Expose dbconn.BaseClient._get_engine by changing it to dbconn.BaseClient._get_engine.

This is needed to operate transactionally as follows:

with db_client.get_engine().begin() as transaction:
    transaction.execute(QUERY_STMT)
    transaction.execute(UPDATE_STMT)

This change is used in delver promoter.

Ref: https://docs.sqlalchemy.org/en/latest/core/connections.html#using-transactions

Edited by Pablo Lorenzatto

Merge request reports