Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
Manuscripts Manuscript Editor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 97
    • Issues 97
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Manuscripts.app Public
  • Manuscripts Manuscript Editor
  • Issues
  • #191

Closed
Open
Created Jan 17, 2020 by Casey Ydenberg@CAYdenbergOwner

manuscripts/manuscript-editor

@alf-eaton @mz2 Seeking objections.

Some upcoming work is going to require us to remix the editor with some element types removed or modified and possibly others added. Re-using this library as it stands actually doesn't make sense because it contains a number of other exported components which won't be used. This is a proving a challenge for code-splitting.

The actual elements which need to be reused are the plugins and nodeViews. I think these "atomic" elements should be moved to a separate repo, making as little assumption about their Schema as possible and exporting themselves as individual entities. The "React code" doesn't require the same treatment at this point, but in future the Editor class could be refactored to use hooks, and then the hooks individually imported where needed.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking