Skip to content

[#642] Add dangerfile

Konstantin Ivanov requested to merge martoon/#642-add-danger-checks into master

Description

This adds some trivial checks by Danger. This tool looks promising because it can easily do things that we couldn't handle properly yet, like checking fixup commits presence.

I do not cause CI failure when Dangerbot finds crucial problems, because some problems are fine while the work is in progress, and keeping CI red during that and getting constant notifications would be annoying. Until we find a better solution, let's treat Dangerbot checks similarly to our MR checklist - the one who merges is responsible for ensuring that all marks are checked.

Related issue(s)

Resolves #642 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Konstantin Ivanov

Merge request reports