Skip to content

[morley-debugger#13] Preserve nested variable annotations

Description

Problem: According to the reference implementation, the Pair value should preserve variable annotations inside itself. However, Morley's NTPair doesn't preserve these annotations.

Solution: Change NTNotes so that NTPair accepts two variable annotations. This causes many places to require changes as well, such as the parser, packer, unpacker etc. Additionally, the untyped TPair was also changed to accept these two variable annotations.

While resolving this, move one test to its own file to simplify things.

See also: morley-debugger!13 (merged)

Related issue(s)

Pre-condition to resolve morley-debugger#13 (closed)

Resolves morley-debugger#14 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Heitor Toledo Lassarote de Paula

Merge request reports