Skip to content
Snippets Groups Projects

[#470] Unpacking/decoding of right-combed pair types

Merged Diogo Castro requested to merge diogo/#470-right-combed-type into master

Description

This MR adds these two things:

  • Ability to parse right-combed types (e.g. pair int nat string) from all 3 formats (binary, micheline, michelson)
  • Ability to parse right-combed values (e.g. Pair 1 2 "a") from the michelson format (the other 2 formats were already implemented in !753 (merged))

Related issue(s)

Resolves part of #470 (closed)

:white_check_mark: Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Diogo Castro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM, have only one minor suggestion

  • Roman Melnikov approved this merge request

    approved this merge request

  • Diogo Castro added 1 commit

    added 1 commit

    Compare with previous version

  • Diogo Castro marked this merge request as draft from b6f571ae

    marked this merge request as draft from b6f571ae

  • Diogo Castro marked this merge request as ready

    marked this merge request as ready

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading