Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
morley
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 129
    • Issues 129
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 25
    • Merge Requests 25
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Morley
  • morley
  • Merge Requests
  • !747

Open
Opened Jan 15, 2021 by Konstantin Ivanov@MartoonDeveloper8 of 8 tasks completed8/8 tasks
  • Report abuse
Report abuse

[#527] Fix generics derivation for unordered sum types

  • Overview 16
  • Commits 2
  • Pipelines 11
  • Changes 4

Description

Problem: it is said that if constructors are not sorted alphabetically, ligoLayout produces invalid code.

Solution: apparently I made a dumb bug when implemented this, applying sorting twice; with this commit this is not the case anymore.

Related issue(s)

Resolves #527

✅ Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
      • Root README and other README.md files
      • Haddock
      • docs/
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

  • My commits comply with the following policy.
  • My code complies with the style guide.
Edited Feb 04, 2021 by Konstantin Ivanov
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: morley-framework/morley!747
Source branch: martoon/#527-fix-unordered-sums-generics-derivation