Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
morley
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 128
    • Issues 128
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 24
    • Merge Requests 24
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Morley
  • morley
  • Merge Requests
  • !727

Merged
Opened Dec 22, 2020 by Heitor Toledo Lassarote de Paula@heitor.toledoDeveloper8 of 8 tasks completed8/8 tasks

[morley-debugger#4] Fix annotations discarded in some instructions

  • Overview 22
  • Commits 2
  • Pipelines 16
  • Changes 22

Description

Problem: Currently, some instructions such as IF_NONE are discarding annotations. According to tezos-client, they should be kept.

Solution: Change the interpreter so that annotations are preserved, in some cases restoring the old annotations. In some polymorphic instructions such as ITER and MAP, create a new method responsible for extracting notes for the polymorphic's value element annotations.

This MR is split in two parts. The second part can be found in morley-debugger!3 (merged).

Related issue(s)

This is a pre-requisite for resolving morley-debugger#4 (closed)

✅ Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
      • Root README and other README.md files
      • Haddock
      • docs/
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

  • My commits comply with the following policy.
  • My code complies with the style guide.
Edited Feb 03, 2021 by Heitor Toledo Lassarote de Paula
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: morley-framework/morley!727
Source branch: heitor.toledo/#499-fix-discarded-annotations