Skip to content

Simplify some Lorentz code

Konstantin Ivanov requested to merge martoon/remove-extra-knownvalue into master

Description

Problem: once I added KnownValue constraint to sopGet because sometimes we need to call none within sopGet and such constraint is required there.

But in fact it is not convenient to have such constraints in primitives like get because one will have to propagate them everywhere in his code. It is better to have this constraint in methods composing Store*Ops because they are usually applied to concrete types and there is no need to propagate constraints.

Solution: remove KnownValue in sopGet, propagate changes.

Related issue(s)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Konstantin Ivanov

Merge request reports