Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
morley
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 130
    • Issues 130
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 23
    • Merge requests 23
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Morley
  • morley
  • Merge requests
  • !702

Closed
Created Dec 09, 2020 by Simon Jakobi@sjakobiDeveloper0 of 12 tasks completed0/12 tasks
  • Report abuse
Report abuse

Draft: [SDAO-297] morley-client: Extend NodeMethods so specific blocks can be queried

  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 2

Description

Problem: For SDAO-297, we need to query big maps and contract storage at specific blocks.

Solution:

  • NodeMethods is extended with new methods getStorageAtBlock and getBigMapValueAtBlock
  • A BlockId type is added that represents different types of block IDs.

Related issue(s)

https://issues.serokell.io/issue/SDAO-297

TODOs (please discuss)

  • For consistency, the Text arguments in getBlockConstants and getHeadBlockOperations are changed to BlockIds
  • To avoid confusion, getHeadBlockOperations is renamed to getBlockOperations
  • For consistency, the remaining methods that are currently specialized to query the head block are generalized to take a BlockId argument
  • To avoid unnecessary growth in NodeMethods, turn "non-primitive" methods like getStorage and getBigMapValue into top-level definitions

✅ Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
      • Root README and other README.md files
      • Haddock
      • docs/
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

  • My commits comply with the following policy.
  • My code complies with the style guide.
Edited Dec 09, 2020 by Simon Jakobi
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: sjakobi/generalize-node-api