Skip to content

[#401] Omit instructions without location in the debugger snapshots

Ilya Peresadin requested to merge pva/#401-handle-macros-correctly into master

Description

Problem: there are several issues revealed by 'pexec.tz' contract. First of them: macro handed incorectly, there is no position for expanded instructions, so cursor jumps to the dummy position (at the 0:0). Second: 'APPLY' instruction produce two auxiliary instructions which don't have associated source position either. Also, there is an issue when we jump to a macro line, the cursors goes to dummy position.

Solution: the solution of two first problems is not to make snapshots for instructions without associated source positions and treat them as auxiliary (either generated by the interepreter or added during the contract processing). The last issues is just a bug which can be fixed by attaching appropriate source location.

Based on #438 (closed) commits.

Related issue(s)

Resolves #401 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Ilya Peresadin

Merge request reports