Skip to content

Draft: [#420] Don't cache `NettestEnv` in Tasty integration module

Diogo Castro requested to merge diogo/#420-nettestenv-cache into master

Description

Problem: we found some very specific scenarios where using unsafePerformIO in Morley.Nettest.Tasty (necessary to create and cache a NettestEnv) can lead to crashes in the CI.

See issue for details: #420 (closed)

Solution: Don't cache NettestEnv, and create a new one every time a test is run.

Related issue(s)

Resolves #420 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Diogo Castro

Merge request reports