Skip to content

[#302] Fix integer conversion in `morley-client get-balance`

Simon Jakobi requested to merge sjakobi/302-get-balance into master

Description

Problem: morley-client get-balance was reporting wrong results for large balances due to an accidental conversion from Int64 to Word32, which truncated balances >= 4294 Tz.

Solution:

  • The NodeAPI type has been changed to return a new TezosMutez type instead of TezosInt64. The conversion to Mutez is handled in the instance FromJSON TezosMutez.

  • To avoid code duplication, parseMutezJson is replaced by relying on FromJSON TezosMutez.

Related issue(s)

Resolves #302 (closed).

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Simon Jakobi

Merge request reports